Fix failure to parse complex CSS values #7487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
fix/complex-css-values
branch
from
4aacb21
to
3022b30
Compare
|
Plugin builds for 27856a7 are ready 🛎️!
|
|
I'm a bit wary of using cc @swissspidy |
westonruter
force-pushed
the
fix/complex-css-values
branch
from
3022b30
to
27856a7
Compare
It makes sense to preserve it for the time being because our plugin appears to function with the changes made to the master up until |
swissspidy
approved these changes
Mar 16, 2023
thelovekesh
assigned westonruter and thelovekesh and unassigned westonruter and thelovekesh
|
QA Passed ✅ Cross-checked the issue, the CSS changes are visible fine. Before: After Also verified in the browser that the complex CSS is enqueued.
|
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7291
8.4.0todev-master, pinning at the most recent commit. Note that php-css-parser hasn't seen areleasetag since December 11, 2021. The update is done in order to benefit from the many PRs merged since (95 commits) then and to use latest PR patches.turnsunit withturnMyIntervals/PHP-CSS-Parser#350 which has been merged intomaster.master.master.